commit f201ea5076a20e1a8b8d15e0c113afe8ba214793 Author: Andrew Auld Date: Thu Apr 3 10:34:47 2025 +0000 Bug 39543: Error modal when trying to add two controlling licences to an agreement duplicates error message If you try to add two licences with the status 'controlling' to an agreement record, the error modal duplicates the error message 'Only one controlling license is allowed'. Test Plan: 1) Enable ERMModule sys pref 2) Add an agreement record 3) Add two licence records 4) Edit the agreement record and associate both license records to the agreement 5) Try to set both licenses to status 'controlling' 6) Note error modal duplicates the error message 'Only one controlling license is allowed' 7) Apply the patch, run yarn js:build and then hard refresh the browser 8) Repeat steps 1 to 5 and enjoy the single error message! Signed-off-by: Magnus Enger I took the liberty of fixing up the commit message a bit. Signed-off-by: Lisette Scheer Signed-off-by: Katrin Fischer commit 33496ed4e40c3b281a58dcb9af23df2b2e2a6e36 Author: Owen Leonard Date: Fri Mar 21 15:11:57 2025 +0000 Bug 39404: Update Cart control to say "Add to list" for consistency This patch update the template for the cart in both the staff interface and OPAC so that the control for adding an item in the cart to a list. To test, apply the patch and log in to the OPAC. - Perform a catalog search in the OPAC which will return multiple results. - From the search results page, check checkboxes next to multiple results and click "Add to cart." - Open the cart by clicking the "Cart" link at the top of the page. - In the cart popup, you should see "Select titles to:" You should see a button labeled "Add to list." - Perform the same test in the staff interface. Signed-off-by: David Cook Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 8251e854d4065af1ac9b15fec208e1d24ff44ecc Author: Phil Ringnalda Date: Fri Mar 21 07:16:42 2025 -0700 Bug 39409: Duplicate modifybiblio ids in cat-toolbar The biblio details page Edit menu has three different elements which all have id="modifybibilio", two of which also have another id. Neither of those things is allowed. Test plan: 1. Without the patch, load the details view for any biblio record and View source 2. Search for id="modifybiblio" 3. You will get three results, the second and third shown with id in red 4. Apply patch, reload the page, View source and search again 5. You will get one result, without any red Sponsored-by: Chetco Community Public Library Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 47647a687e3536441d01739e714385582a696142 Author: Andrew Fuerste Henry Date: Thu Mar 20 19:22:04 2025 +0000 Bug 39258: Remove extra nonfunctional Delete button from report preview modal To test: 1 - save a report 2 - click Preview SQL for that report from the Saved Reports page 3 - see there are two delete buttons 4 - apply patch, reload page 5 - now there is one delete button 6 - confirm that delete button gives a confirmation message and then deletes the report 7 - Install a second language for the intranet 8 - switch to that language and confirm you have just 1 delete button, it is translated, and it works Signed-off-by: David Nind Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit b390be07fd3a4922ac6b711c984e943351c8ba79 Author: Owen Leonard Date: Thu Mar 20 16:45:46 2025 +0000 Bug 38294: Fix layout of checkbox/label when editing search filters This patch makes a minor markup change in order to improve the alignment of controls for editing a search filter in the staff interface. To test, apply the patch and make sure the SavedSearchFilters system preference is enabled. - In the staff client catalog, perform a search. - At the top of the search results, click "Save search as filter". - Fill out the form and save the search filter. - Go to Administration -> Search filters. - Click the "Edit search" button for your filter. - You should be returned to the advanced search page and there should be an "Editing filter" form at the top. The "Show in OPAC" and "Show in staff interface" labels and checkboxes should be aligned neatly with the buttons in the toolbar. Sponsored-by: Athens County Public Libraries Signed-off-by: Phil Ringnalda Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer commit 1b5041046f16409051ae06c41e66ad483fa23792 Author: Jonathan Druart Date: Mon Mar 17 09:39:47 2025 +0100 Bug 39350: (bug 38664 follow-up) Restore language selector for Vue.js module ERM and Preservation modules have lost the language selector during the tidy work. There has been a closing div added to the "home" files, which broke the HTML structure. Test plan: Have more than one language selected for StaffInterfaceLanguages. Go to the ERM and Preservation module and confirm that with this patch applied the language selector menu is displayed. Signed-off-by: David Nind Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 78d24e08b5f90746419a45727be9ebe98ece9407 Author: Jonathan Druart Date: Tue Mar 18 16:20:28 2025 +0100 Bug 39368: Remove warnings from t::lib::Mocks::Zebra because of statement after exec we get: # Previous test 1217 'POD coverage for t/lib/Mocks/Logger.pm' # Statement unlikely to be reached at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # at /kohadevbox/koha/t/lib/Mocks/Zebra.pm line 119. # require t/lib/Mocks/Zebra.pm called at (eval 4894) line 1 # eval ' require t::lib::Mocks::Zebra ' called at /usr/share/perl5/Pod/Coverage.pm line 308 # Pod::Coverage::_get_syms(Pod::Coverage=HASH(0x569d3a0bbf50), "t::lib::Mocks::Zebra") called at /usr/share/perl5/Pod/Coverage.pm line 152 # Pod::Coverage::coverage(Pod::Coverage=HASH(0x569d3a0bbf50)) called at /usr/share/perl5/Pod/Coverage.pm line 209 # Pod::Coverage::naked(Pod::Coverage=HASH(0x569d3a0bbf50)) called at xt/author/pod_coverage.t line 40 # main::check_pod_coverage("t/lib/Mocks/Zebra.pm") called at xt/author/pod_coverage.t line 30 Test plan: Run `prove xt/author/pod_coverage.t` and confirm that the tests pass with this patch applied. Also confirm that t/db_dependent/www/search_utf8.t still passes Note that xt/author/pod_coverage.t is coming from bug 39367. Signed-off-by: Magnus Enger Tested on top of bug 39367. Patch makes the mentioned tests pass. Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit f3080cbe5b5eab5ca0a79c3ac4b5017cc61cb6cc Author: Emily Lamancusa Date: Mon Mar 31 10:14:10 2025 -0400 Bug 39400: (QA follow-up) Adjust link text Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit fcf705e2e3d48f1600b064d6ef7e67b7ec24fce1 Author: Phil Ringnalda Date: Fri Mar 21 06:09:10 2025 -0700 Bug 39400: "Jump to add item form" doesn't work while editing an existing item The link at the top of the item editor page to "Jump to add item form" tries to scrollIntoView the element with id="additema", but that element only exists while you are adding a new item. While you are editing an existing item, it is replaced by an element with id="edititem". Whichever element you have at the moment is always just below the form with id="f", so we can just scroll that into view instead. Test plan: 1. Without the patch, go to the details page for any bib record with at least one item, and click the Edit button on the row for an item in the holdings table. 2. You should be scrolled down to the form for editing that item 3. Scroll up to the top of the page, click the Jump to add item form link 4. You will not be scrolled back down to the form 5. Apply patch, shift+reload page 6. Now the link should scroll you back down to the form 7. Return to the biblio details page, click Edit - Manage items and verify that the Jump to add item form link still works when you are not editing an existing item 8. Click the Add multiple copies of this item button and add 30 items 9. Make sure that the link still scrolls the form into view both while you are editing an existing item, and while you are adding a new item Sponsored-by: Chetco Community Public Library Signed-off-by: Owen Leonard Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 7fb30a073e56faa7e27c627ba641c8ba4006ca26 Author: Marcel de Rooy Date: Mon Mar 31 09:51:19 2025 +0000 Bug 39226: (follow-up) Similar change for the cud-update branch Resolve DBIx::Class::Storage::DBI::insert(): Missing value for primary key column 'verification_token' on BorrowerModification Test plan: Update details for existing borrower. Signed-off-by: Paul Derscheid Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit c7bdbf937c4411e80883b6d41afe63670d592d50 Author: Marcel de Rooy Date: Mon Mar 3 13:09:12 2025 +0000 Bug 39226: Add borrowernumber 0 when creating patron modification Test plan: Test with and without this patch. Verify that you see no warn with Missing value for primary key column anymore in plack-opac-error. Enable self registration. Register a new patron. Signed-off-by: Paul Derscheid Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit db44d917ef634d6e8640dbfabbfd9aa124d9e60a Author: Lucas Gass Date: Tue Mar 11 16:53:28 2025 +0000 Bug 39307: Check to make sure there is a document.referrer To test: 1. Navigate to circ/circulation.pl?borrowernumber=X 2. See the console error `document.referrer.split(...)[1] is undefined` 3. Go to circ home circ/circulation-home.pl and search for a patron 4. See the console error when you select a patron or are taken directly to them 5. APPLY PATCH 5. JS error should be gone in both instances squash Signed-off-by: Lucas Gass Signed-off-by: Brendan Lawlor Signed-off-by: Katrin Fischer commit 8ea3785f0f5577ffc270d0452a1edeb897d05989 Author: Jonathan Druart Date: Tue Jan 28 12:28:27 2025 +0100 Bug 38440: Remove useless handling of .dt_button_clear_filter There is only one occurrence in the whole codebase, we should not handle the behaviour of this "clear filter" button outside of datatables.js Test plan: Go to Additional content Use the form on the left side of the page, confirm that the table is filtered when a new keyword is entered Notice that the global search of the table is filled in with the keyword "Clear filters" should reset both inputs, and redraw the table Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 70e43a0553130d234841a99f8221c17ab950d199 Author: Janusz Kaczmarek Date: Thu Apr 3 12:51:35 2025 +0000 Bug 39544: New > New record generates warnings in log When creating a new record starting from Normal records view, by using New > New record warnings in the log will be generated like: [2025/04/03 12:45:33] [WARN] Use of uninitialized value $frameworkcode in string eq at /kohadevbox/koha/cataloguing/addbiblio.pl line 513. Test plan: ========== 1. In staff interface, open any record in Normal view. 2. From upper menu chose New > New record. 3. Check the plack-intranet-error.log file, you should see fresh warnings with "Use of uninitialized value $frameworkcode". 4. Apply the patch ; restart_all. 5. Repeat p. 1.-3. No new warnings. Signed-off-by: Magnus Enger Signed-off-by: Caroline Cyr La Rose Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit 5cf5811d01e00e907045c8f9e97fef4ce380184c Author: Nick Clemens Date: Wed Apr 2 11:54:03 2025 +0000 Bug 22458: Don't check for duplicate email on borrower self modification This patch adds an extra variable to internal function CheckValidBorrower to set the context as 'create' or 'update' To test: 1 - Enable PatronSelfRegistrationEmailMustBeUnique 2 - Edit a patron in staff interface and set email to 'a@example.org' 3 - Open an incognito window and go to opac 4 - Self register a patron using email a@example.org 5 - You receive an error 6 - Use b@example.org for email 7 - No problem 8 - Sign in as the new patron 9 - Edit your information 10 - Set email to a@example.org 11 - You receive an error 12 - Apply patch, restart all 13 - Edit patron again 14 - No error! 15 - Register another patron on the opac 16 - Confirm still wanred if using a@example.org as the email Signed-off-by: Allax Guillen Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit c969fad2c25c54e2f0e96cbf2941339e55f87c14 Author: Katrin Fischer Date: Fri Apr 11 09:52:22 2025 +0200 Bug 39188: Update yarn.lock Signed-off-by: Katrin Fischer commit 2b9eb2be181fb3ae0765a610b1203978188e5220 Author: Victor Grousset Date: Mon Feb 24 05:41:50 2025 +0100 Bug 39188: Fix ESLint by Updating "globals" node package According to the main dev of ESLint, we should add it to devDependencies because we are the ones calling globals from eslint.config.mjs: https://github.com/eslint/eslint/issues/19209#issuecomment-2518452107 Test plan: 1. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue 2. TypeError: Key "languageOptions": Key "globals": Global "AudioWorkletGlobalScope " has leading or trailing whitespace 3. :( 4. Apply patch 5. sudo yarn install --modules-folder /kohadevbox/node_modules 6. run: eslint ./koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/AgreementsFormAdd.vue 7. eslint output a report about the issues found in the file 8. signoff :D Signed-off-by: Magnus Enger Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit 45f8762c40a5e341ee9d1af992d8bb6102fcc9a8 Author: Julian Maurice Date: Wed Apr 2 15:31:51 2025 +0200 Bug 39298: (QA follow-up) Add missing html filter Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer commit 4daf0b79820d757332344cba6e0e10fbfb09b22e Author: David Cook Date: Tue Mar 11 05:00:18 2025 +0000 Bug 39298: Add runtime parameter support to report templates This change makes it so that you can provide runtime parameters and use "Run with template". Test plan: 0. Apply the patch and koha-plack --restart kohadev 1. Create a report template. For example: [% FOREACH row IN data %] [% END %]
Transformed Biblionumber
Biblionumber [% row.biblionumber %]
2. Create a SQL report with a runtime parameter. For example: SELECT biblionumber FROM biblio WHERE biblionumber > <> 3. Run the report using "Run with template" 4. Specify a biblionumber of 1 5. Click "Run the report" 6. Note that the output is the template output and not regular SQL output Signed-off-by: David Nind Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer commit e1372bacdf312a03fee98a33e8217ce4b65614b7 Author: Martin Renvoize Date: Fri Mar 21 15:16:48 2025 +0000 Bug 39410: Use shadowDOM for notice display modal This patch updates the notice display modal found in the members > notices page to use a shadowDOM to more accurately display notices matching how they should display for patrons in their email clients or when printed. Test plan 1) We can use the 'WELCOME' print notice introduced in bug 38087 as it includes Bootstrap classes for display. 2) Navigate to the 'Henry' user in KTD and use the 'More > Send welcome notice' option to trigger a print notice. 3) Navigate to the 'Notices' tab for the 'Henry' user and click on the notice title to trigger the display modal. 4) Note the well formatted notice with an address block on the right and some sections in bold. 5) Apply this patchset 6) Display the notice again as in step 3 and note that the foratting is now lost. This is showing proper scoping of the CSS in the same way that the notice will be displayed to the end user when printed using batch printing. Note: Whilst this degrades the look of the notice in the staff client, that is actualy highlighting a mistake in the notice template or possible showing that we should be including bootstrap in the print notices template... that is for another bug. Signed-off-by: Brendan Gallagher Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 8779674f1f85cdc8e870dabfed0854e2f468568c Author: Owen Leonard Date: Tue Apr 1 14:27:34 2025 +0000 Bug 39513: Correct OPAC subscription tables DataTable initialization This patch corrects an error in the OPAC subscription tables DataTable initialization which arose from merging of Bug 36553. The table should be initialized by class (see Bug 35202). To test you should have a bibliographic record with multiple subscriptions and items attached to each. - In the OPAC, view the detail page for that bibliographic record. - View the Subscriptions tab. All subscription tables should be sortable DataTables which follow the configuration set in staff client Administration -> Table settings -> OPAC -> subscriptionst. - Click another tab, e.g. Holdings. - Click back to the Subscriptions tab. The tables should remain the same: Sortable tables with no other DataTables controls. Sponsored-by: Athens County Public Libraries Signed-off-by: Laura_Escamilla Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer commit 317b70b7b67ae5eb83e3b0c4cf2eee89f016a880 Author: Janusz Kaczmarek Date: Wed Dec 18 11:20:39 2024 +0000 Bug 34739: Linked biblios should not be merged (updated) when changes to an authority don't change the authorized heading Currently, the function C4::AuthoritiesMarc::merge calls ModBiblio for all bibliographic records linked to the modified authority record. It could seem a just behavior but we know that this could lead to performance problems. This is why AuthorityMergeLimit systempreference with merge_authorities.pl was introduced (earlier: dontmerge). Although this partially solves the performance problems, for moderately large and large catalogs (500+ K) and authority records linked with a large number of bibliographic records, performance problems still occur, even with overnight processing with merge_authorities.pl. This problem is particularly apparent when updating authority records from central databases, whose modifications are beyond our control. It turns out, however, that many such modifications to authority records involve fields other than the heading field (1XX in MARC 21), so these updates in fact do not modify bibliographic records. However, with the current merge function, every touch on an authority record forces a call to the ModBiblio function. The number of relatively expensive ModBiblio calls could be reduced by checking whether there has been an actual change in the field associated with the authority record. However, with IncludeSeeFromInSearches or IncludeSeeAlsoFromInSearches preferences enabled, the record should be refreshed in the search engine just in case (should the 4XX, 5XX fields have changed, which we don't know at this point). Test plan: ========== 1. Make sure to have CataloguingLog set to Log and IncludeSeeFromInSearches set to Include. 2. Have a bibliographic record with an authority record linked. Open the authority record in a separate tab, open it in the editor and save, without modifying it. Repeat this 2-3 times. In the bibliographic record tab open the Modification log and see a number of entries - for each “empty” modification of the linked authority record. 3. Apply the patch ; restart_all. 4. Repat p. 2. Note that there are no new entries in the log. 5. Edit the authority record again, this time putting in one of the proper 4XX $a subfield an uncommon word (but do not touch the 1XX field). Save the authority record. In the bibliographic record tab control that there are no new entries in the modification log. Make a search for the word put in 4XX field. You should get the bibliographic record(s) linked to the edited authority record, even though the bibliographic record itself has not been modified. 6. Edit the authority record again, this time changing the 1XX field. Save the authority record. In the bibliographic record tab control that there are is new entry in the modification log. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny Signed-off-by: Thomas Klausner Signed-off-by: Katrin Fischer commit bb0e35ac6b92e23179b8231b26e242b5b5b74103 Author: Janusz Kaczmarek Date: Wed Dec 18 14:19:55 2024 +0000 Bug 34739: Unit tests BTW, there is a tiny adjustment to one of the previous subtests to fit to the modified merge behaviour. Signed-off-by: Roman Dolny Signed-off-by: Thomas Klausner Signed-off-by: Katrin Fischer commit 0ab24fd216dd58087917ff9f9bc8e8cb61c30950 Author: Emily Lamancusa Date: Mon Mar 31 09:40:46 2025 -0400 Bug 39089: (QA follow-up) Apply the same fix to from address and CC address Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit fdc7a8eb4a9d709da76b213f6b7c2095cf76d3d8 Author: Lucas Gass Date: Tue Feb 11 00:10:24 2025 +0000 Bug 39089: Do not show an email address when the tranport type is print To test: 1. Set a overdue trigger for print notice 2. Set up an overdue to be captured by overdue_notices.pl 3. Make sure the patron has an email address 4. Run overdue_notices.pl 5. Run gather_print_notices.pl 6. Now go to the patron's notice page (members/notices.pl?borrowernumber=x) 7. Find the print row for the overdue just generated. 8. See that under the 'Delivery note' it says "To: test@test.com". 9. APPLY PATCH 10. Try again, you should now see no "To:" field when the transport type is print 11. Make sure that when the transport type is anything but print, you do see it. Signed-off-by: Magnus Enger Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 097153f27982c5b65fb3503320cfd9404e23fd47 Author: Lucas Gass Date: Mon Mar 17 15:08:23 2025 +0000 Bug 39361: Wrap modal JS in document ready function To test: 1. Find or create an item with a hold on it. 2. Go to Circulation > Transfers 3. Transfer the item from step 1. 4. No modal appears to warn that the item has a hold. 5. APPLY PATCH 6. Try step 3 again, this time the modal should appear correctly. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit fc2730d0f4e295a0bd932c59db876e110f4cc775 Author: Jonathan Druart Date: Mon Mar 17 11:46:50 2025 +0100 Bug 39346: Display all additional fields getAll should call getAll, not get, or we lose the _per_page=-1 parameter. Test plan: Have more than 20 additional fields for agreements Create and agreement: => Notice that with this patch, all the fields are displayed. Signed-off-by: David Nind Signed-off-by: Matt Blenkinsop Signed-off-by: Katrin Fischer commit b1efa3d71d3ab65d3d8001782e3761f5d9911ee2 Author: Jonathan Druart Date: Tue Mar 11 10:37:44 2025 +0100 Bug 39300: Fix quick edit of subfields Searching tag$subfield in the framework should redirect to the edition of the tag with the subfield tab selected. This has been broken when we used the wrapper for tabs on bug 33178. Test plan: Edit a framework http://localhost:8081/cgi-bin/koha/admin/marctagstructure.pl?frameworkcode= Search for 952$c => You are redirected to the edition of 952 and the "c" tab is selected Signed-off-by: Owen Leonard Signed-off-by: Julian Maurice Signed-off-by: Katrin Fischer commit 5426ae5bfd793d0e233c2d04d21c993f22abfc75 Author: Martin Renvoize Date: Thu Feb 27 15:40:18 2025 +0000 Bug 39209: Set cookie consent bar as first focus This patch updates the cookie consent javascript, when the feature is enabled, to ensure that the cookie consent bar gets focused when it displays. Test plan 1) Enable the CookieConsent preference 2) Open any OPAC page 3) Hit 'tab' and note the display of 'Skip to main content' 4) Confirm that the cookie consent bar is displayed and continued 'tabs' eventually navigate to it 5) Apply this patch 6) Navigate to any OPAC page 7) Hit 'tab' and note that the 'Cookie consent' bar is focused, your keyboard navigation starts with the cookie consent buttons 8) Accept the essential cookies 9) Hit tab and note the focus is back to normal and shows the 'Skip to main content' button on first keyboard navigation. Signed-off-by: Owen Leonard Amended-by: Jonathan Druart Run tidy.pl Signed-off-by: Thomas Klausner Signed-off-by: Katrin Fischer commit 45561b66142c7f198c880fe41f9db41f2d7d4f04 Author: Lucas Gass Date: Mon Mar 10 22:24:49 2025 +0000 Bug 39294: Fix includes to properly remember selections To test: 1. Cataloging > Stage MARC record for import 2. Upload a MARC file 3. Change some of the following settings: -Action if matching record found: -Action if no match is found: -How to process items/Item processing: 4. Stage for import and View batch 5. None of this settings have been retained. 6. APPLY PATCH 7. Try these steps again, now the settings should be remembered 8. Turn on the 'MarcOrderingAutomation' system preference. 9. Administration > MARC order accounts 10. Create a new account 11. Change the "Record matching settings" and submit 12. Make sure every selection is remembered when you edit the account. Signed-off-by: Sam Sowanick Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 9cebd54ab13efa4024708b6c56b92e34f20dd2d9 Author: David Nind Date: Sat Dec 28 05:34:32 2024 +0000 Bug 31019: Fix broken links to UNIMARC field documentation IFLA no longer provides field-level documentation pages for the UNIMARC format (as at December 2024). It only provides: - updates by year as individual PDFs (there may be multiple PDF updates for a field) - a single consolidated PDF that is not yet endorsed by IFLA. This patch updates the default UNIMARC field documentation links to https://www.ifla.org/g/unimarc-rg/unimarc-updates/ It also: - makes minor formating changes to improve consistency with the advanced editor: . the help link text is now [?], instead of ? . adds hover text for [?] - "Show help for this tag" . adds some additional spacing before the indicator fields . removes the '-' before the tag title - updates the MarcFieldDocURL system preference description Test plan: 1. Start up a Koha instance that uses UNIMARC (if using koha-testing-docker, change KOHA_MARC_FLAVOUR=unimarc in your .env file). 2. Set the EnableAdvancedCatalogingEditor system preference to "Enable". 3. Search for and edit any bibliographic record using the basic editor. 4. Click on the help text link (?) after any tag. 5. Note that you get an error: - Firefox: "The page isn’t redirecting properly" - Chrome-based browsers: "This page isn’t working archive.ifla.org redirected you too many times." 6. Switch to the advanced editor (Settings > Switch to advanced editor). 7. Click on a tag and then click the help link ([?]) at the bottom of the page. Result: You get the an error for the web page. 8. Switch back to the basic editor (Settings > Switch to basic editor). 9. Apply the patch. 10. Duplicate the tab and refresh the page for the record you were editing. 11. Click a help link for the basic editor - it now goes to a valid web page (https://www.ifla.org/g/unimarc-rg/unimarc-updates/). 12. Compare the basic editor page to the previously opened tab and note these differences: - the help link text is now [?], instead of ? - there is now hover text for [?]- "Show help for this tag" - there is some additional spacing before the indicator fields - there is no '-' before the tag title 13. Check that the page looks okay if the Settings > Show MARC tag document, and Show tags options are toggled off. 14. Switch to the advanced editor (Settings > Switch to advanced editor). If you click on the help link you now go to a valid web page. 15. View the updated description for updated MarcFieldDocURL system preference and check that it makes sense. 16. Enter a URL for the MarcFieldDocURL system preference, for example, https://example.com 17. Edit another record (using either the basic or advanced editor) and click the help link - it should take you to the web page you set for MarcFieldDocURL. 18. [Optional] Enter a custom URL pattern for the help documentation using {FIELD} (I don't know of any UNIMARC custom URL patterns). 19. Repeat the steps as appropriate for a MARC21 instance: 19.1 Start up a MARC21 instance (change KOHA_MARC_FLAVOUR=unimarc on your .env file). 19.2 The help links should take you to the Library of Congress MARC pages. 19.3 Check that custom URL patterns continue to work, for example, use the Canadian custom URL pattern http://www.marc21.ca/MaJ/BIB/B{FIELD}.pdf 20. Sign off! Signed-off-by: David Nind Signed-off-by: Mathieu Saby Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 1bb962bba71194f5e19b22935bd048c8680333b9 Author: Adolfo Rodríguez Date: Fri Mar 7 12:39:49 2025 +0100 Bug 38411: Check mandatory item fields when creating several items ordering or receiving. This patch adds a check of mandatory item fields when adding several items Test plan: 1 We need mandatory subfields for items in the ACQ framework and an open basket configured to create items on order or a closed basket configured to create items on receiving an order 2 In both cases, in the form to create items check that there are mandatory fields. 3 Click the Add multiple items button, write a number and then add. 4 Check that the items have been added. 5 Apply patch, restart services 6 Repeat step 3 Now it doesn't add the items and shows an alert regarding the empty mandatory fields Signed-off-by: Laurence Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 81b6c3cf270c0675ecec8a2bef1cfee5d05e94aa Author: Janusz Kaczmarek Date: Wed Mar 26 17:39:51 2025 +0000 Bug 39462: Unit tests Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit cfe3421891e8942f261df1d0aa6d0dba17b3f166 Author: Janusz Kaczmarek Date: Wed Mar 26 17:33:37 2025 +0000 Bug 39462: (bug 37870 follow-up) Default values from framework are inserted into existing record while editing Due to changes made by the commit 0472b56a671, when editing an existing bibliographic record a default value is inserted while it should not, according to ApplyFrameworkDefaults systempreference. Test plan: ========== 1. Verify that ApplyFrameworkDefaults systempreference is set to ‘when cataloguing new records only’. 2. Take any existing bibliographic record, e.g. sn:1. Open it in standard editor and identify a non used (empty) subfield, e.g. 024 $a. Note the framework (Books, Booklets, Workbooks). Close the editor (Cancel). 3. Modify the framework in question (Books, Booklets, Workbooks) by setting a default value for the chosen subfield (e.g. 024 $a). 4. Open the record in the editor again. Note that the 024 $a subfield has now an inserted default value while it should not, according to the ApplyFrameworkDefaults setting. Do not save the record, chose Cancel. 5. Apply the patch ; restart_all. 6. Repeat p. 4 -- there should be no default value inserted in the existing record now. Sponsored-by: Pontificia Università di San Tommaso d'Aquino (Angelicum) Signed-off-by: Roman Dolny Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit f7f5d8056a178ab4dbd0cfe30b487e038f9f35a2 Author: Jonathan Druart Date: Thu Mar 20 13:48:03 2025 +0100 Bug 39395: Fix #wrapper closing tag in sco The module was displayed at the bottom of the screen. It's caused by the closing tag of #wrapper that has been added by bug 38664 inside the include file. It is wrong, the div.main should be within #wrapper. The correct fix is to move #wrapper out of the include file, so that the HTML structure is correct (and the prettier plugin is happy) in the .tt files Test plan: Confirm the bug Apply this patch Go to the SCO module and confirm that the module is correctly placed at the top of the screen Please review this patch using `git show -w HEAD` Signed-off-by: David Nind Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit ef4d0aa5c58966005b25e9895cfd55d92f250cce Author: David Cook Date: Tue Apr 1 01:52:27 2025 +0000 Bug 39460: Fix koha-upgrade-schema when no DB change needed This patch fixes koha-upgrade-schema so that it returns an exit code of 0 whether or not a DB change is needed. This is important so that koha-common.postinst proceeds correctly even when there is no DB change needed (e.g. for 24.11.03-2) Test plan: 0. Apply the patch 1. cp debian/scripts/koha-upgrade-schema /usr/sbin/koha-upgrade-schema 2. dpkg-reconfigure koha-common 3. Note the process completes correctly 4. koha-upgrade-schema kohadev 5. Note following text appears very quickly: Upgrading database schema for kohadev No database change required 6. koha-mysql kohadev update systempreferences set value = '24.1102000' where variable = 'Version'; 7. Clear memcached 8. koha-upgrade-schema kohadev 9. Note that it applies the 24.11.03 database upgrade Signed-off-by: Jonathan Druart Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer commit 38d9b0d11078549ec673987a116088ebcf5016d8 Author: Martin Renvoize Date: Tue Mar 25 15:00:14 2025 +0000 Bug 39447: Update mailmap to reflect PTFS-Europes rename PTFS Europe is now officially Open Fifth Signed-off-by: Martin Renvoize Signed-off-by: Paul Derscheid Bug 39447: (follow-up) Corrections to existing mappings I thought it worked through from top to bottom and thus the lower down mappings would correct the higher up ones.. I was mistaken, thanks Jonathan for pointing that out Test with: 1. `git shortlog --summary --numbered --email | grep ptfs-e` 2. `git shortlog --summary --numbered --email | grep openfifth` Amended-by: Jonathan Druart Space adjustements Signed-off-by: Jonathan Druart commit bfd593946852ec859052a61d10962f6f59b658b0 Author: Jonathan Druart Date: Mon Mar 24 10:31:41 2025 +0100 Bug 37273: Fix Cypress tests Signed-off-by: Jonathan Druart commit 31789383aa25aa2f2a8da77318dcf383b12794d9 Author: Martin Renvoize Date: Fri Mar 21 12:43:13 2025 +0000 Bug 38087: (follow-up) Add missing div to template We lost a closing div somewhere during the life of this patchset Signed-off-by: Katrin Fischer commit ede4088d7a082dcb4ab7de3b399b7b9b2858d506 Author: Martin Renvoize Date: Fri Oct 4 12:45:07 2024 +0100 Bug 38087: Add print template for WELCOME notice at install time This patch adds a default print template for the welcome notice. It will be installed at install time but will not be added at upgrade time. It will also be available as the default under the notice templates tool. Test plan 1) Apply the patch 2) Under 'Tools > Notices and Slips' select the 'WELCOME' notice to edit 3) Click 'View default' under the 'Print' message transport type 4) Note the new default template is shown 5) Use 'Copy to template' to apply it to the notice 6) Use a user (Henry perhaps under sandboxes) without an email address to test the template by 6a) Under 'more' click 'Send welcome notice' 7) Preview the pending print notice under the patrons notices tab by clicking the notice title. 8) Confirm the notice looks reasonable and sign off Signed-off-by: Laura_Escamilla Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 207cb5924101c1807e584df21000acfec3a1a8e7 Author: Owen Leonard Date: Fri Mar 14 17:52:08 2025 +0000 Bug 31167: Only mark due dates in the past red on overdues report This patch adds information about whether an entry in the overdue report is overdue so we can style dates accordingly. We can't assume that each result is overdue because the report can be changed to include all checked out items. To test, apply the patch and go to Circulation. - Check out to a patron. - Use the "Specify due date" option to check out some items with due dates in the past, due dates today, and due dates in the future. - Go to Circulation -> Overdues. - You should see the items which have due dates in the past. The date in the "Due date" column should be red text. The "Checked out on" date should be regular text. - In the sidebar, check the "Show any items currently checked out" checkbox and submit the form. - You should now see all the items you just checked out. Only the overdue items should show their due date in red. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 3888d1ee7ac51b131f22f00fbe732eb23c75eccc Author: Lucas Gass Date: Tue Mar 11 16:57:47 2025 +0000 Bug 39283: Concat middle name with preffered name if it exists 1. Have a patron with a middle name 2. Do a patron search that brings them up, no middle name appears 3. APPLY PATCH 4. Try again, middle name should appear in patron searches. QA follow-up: made the same fix inline for other_name Signed-off-by: Bibliothèque Ifao Signed-off-by: Emily Lamancusa Signed-off-by: Katrin Fischer commit 4f170fb94d351577eba4f3463de025830426992f Author: Lucas Gass Date: Fri Mar 14 22:28:37 2025 +0000 Bug 39331: If patron category cant be guarantee do not continue with add_guarantors To test: 1 - Remove age limits from a Child and Adult category in Administration->Patron categories. Ensure Child category can be guarantor and Adult cannot 2 - The above step is to avoid any age checks and form resubmission which removes the guarantor fields 3 - Find/create a child patron 4 - Add a guarantee from the Adult category to the child 5 - Check the DB: SELECT * FROM borrower_relationships WHERE guarantee_id={borrowernumber of child}; 6 - Note the id colum 7 - Edit the child patron to Adult category 8 - Repeat 5 9 - Note the relationship still exists and the id is incremented 10 - Oof! 11 - APPLY PATCH, restart_all 12 - Try again steps 3 - 8 13 - The relationship should not be re-added 14 - Try with more than 1 guarantor on the record, confirming all are deleted 15 - Try adding some guarantor to patron types that should be able to, they relationship should work. 16 - Try changing some patrons to categories that do allow guarantors, making sure the relationship does stay. Signed-off-by: David Nind Signed-off-by: Baptiste Wojtkowski Signed-off-by: Katrin Fischer commit 6e4039b72ad7294c48ece116a10db493b4d1aafa Author: Jonathan Druart Date: Thu Mar 20 15:28:55 2025 +0100 Bug 39396: (bug 38714 follow-up) Restore options in Batch item modification We built select_class but never used it. Test plan: Go to Batch item modification and confirm that the select2 dropdown lists are no longer empty Signed-off-by: Owen Leonard Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 4eececb3305b5a5093ca98d8515cccc7b85d57a1 Author: Jonathan Druart Date: Wed Mar 12 15:44:11 2025 +0100 Bug 38981: Directly use the opac-image link Signed-off-by: David Nind Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit 545ff24dd0e7858abe940884fb77088e8ac79ba9 Author: Owen Leonard Date: Tue Mar 11 15:07:27 2025 +0000 Bug 38981: Local cover images failing to load in OPAC search results This patch uncomments some code which was incorrectly left commented after debugging. Signed-off-by: David Nind Signed-off-by: Lucas Gass Signed-off-by: Katrin Fischer commit a629a518f529a3f5849ab5b0d463ab8f242b98f2 Author: Katrin Fischer Date: Thu Mar 20 16:07:20 2025 +0000 Bug 38494: DBRev 24.12.00.020 Signed-off-by: Katrin Fischer commit ebba76f1b75ee26f8dca21c240f936b144d7750b Author: Janusz Kaczmarek Date: Thu Mar 20 15:16:49 2025 +0000 Bug 38494: (follow-up) Text amendments clarifying that it is about MARC21 records Refers to ConsiderHeadingUse and ShowHeadingUse systempreferences. Signed-off-by: Katrin Fischer commit f307624049b3a1347f5dc4ebd0d85cfa6e449aac Author: Marcel de Rooy Date: Fri Mar 14 10:04:16 2025 +0000 Bug 38494: (QA follow-up) Add comment and extend pref desc See BZ comment18. Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer commit 4330e1f51479d1e836911cae46c09eae5657e1aa Author: Janusz Kaczmarek Date: Wed Nov 20 13:18:05 2024 +0000 Bug 38494: Koha should consider authority heading use in cataloging In MARC 21 authority records, three bytes (008/14-16) indicate what the heading can be used for (main/added entry, subject entry, series entry). Koha should be able to respect the record's intended use in authority search during cataloging, provided that the authority file is well formed. Also, we should be able to decide between more strict but correct behavior and current lax behavior. Test plan: ---------- 1. Apply the patch; updatedatabase ; restart_all 2. Set the ShowHeadingUse system preference to ‘Show’ 3. Go to the Cataloging editor and open the authority finder plugin for the 100 field. Search for Peter. With standard ktd test data you should get 9 results, some with ‘v’ before Main/Added Entry, some with ‘x’. These with ‘x’ are not to be used in this context, provided you use a well-formed authority file 4. Set ConsiderHeadingUse system preference to ‘Do’ 5. Repeat p. 3. You should get now only 4 Peters – those with ‘v’ before Main/Added Entry (008/14 = ‘a’) 6. You can repeat the test for subject headings (6XX) and series headings (sometimes you would have to modify the test data, e.g. there are few authority records with 008/16 = ‘a’ (series use) 7. This should work equally with Zebra and with Elasticsearch Sponsored-by: Ignatianum University in Cracow Signed-off-by: Roman Dolny Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fischer